michal/tbf
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FixedStartMassCollection fixes, ver. 2.26.1770

Browse Source
This commit is contained in:
Milan Hanajik 2021-10-05 15:39:28 +02:00
parent 4021ed1a7b
commit f725c2d2d8
4 changed files with 41 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
TBF/BenchControl/DataEntry/S620/FormForMechanicalMeters.cs
View File

@ -630,8 +630,8 @@ namespace TBF.BenchControl.DataEntry.S620
foundMeters.Clear(); foundMeters.Clear();
OracleCommand cmd2 = new OracleCommand("select VT_FERNUM, ZAEHLERNUMMER, HYDR_PRUEFUNG from VT_ZAEHLER_PD" + OracleCommand cmd2 = new OracleCommand("SELECT vt_fernum, zaehlernummer, hydr_pruefung FROM vt_zaehler_pd" +
" where ANBID=:1 AND AUFTRAGSNUMMER=:2 order by ZAEHLERNUMMER asc", connection); " WHERE anbid=:1 AND auftragsnummer=:2 ORDER BY zaehlernummer ASC", connection);
cmd2.Parameters.Add(new OracleParameter { OracleDbType = OracleDbType.Int32, Value = ProcessData.OracleDB.Anbid_Producer }); ///:1 cmd2.Parameters.Add(new OracleParameter { OracleDbType = OracleDbType.Int32, Value = ProcessData.OracleDB.Anbid_Producer }); ///:1
cmd2.Parameters.Add(new OracleParameter { OracleDbType = OracleDbType.Varchar2, Value = orderNr }); ///:2 cmd2.Parameters.Add(new OracleParameter { OracleDbType = OracleDbType.Varchar2, Value = orderNr }); ///:2

38
TBF/BenchControl/Elde/StartMeasurementOp.cs
View File

@ -211,24 +211,28 @@ namespace TBF.BenchControl.Elde
double freqLo = 2000.0 * reqFlowLo / nominalFlow; double freqLo = 2000.0 * reqFlowLo / nominalFlow;
double freqHi = 2000.0 * reqFlowHi / nominalFlow; double freqHi = 2000.0 * reqFlowHi / nominalFlow;
if (regulValve.IsCoax) if ((testMethod & TestMethods.FixedStart) == 0)
{ {
controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency, /// This is not a fixed start method => Start flow regulation
new float[2] { (float)((freqLo + freqHi) / 2), (float)((freqLo + freqHi) / 2) }, if (regulValve.IsCoax)
regulValveStableTime); {
} controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency,
else if (regulValve is RegulValveMilwaukee.RegulValve) new float[2] { (float)((freqLo + freqHi) / 2), (float)((freqLo + freqHi) / 2) },
{ regulValveStableTime);
controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency, }
new float[2] { (float)freqLo, (float)freqHi }, else if (regulValve is RegulValveMilwaukee.RegulValve)
regulValveStableTime, {
true); controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency,
} new float[2] { (float)freqLo, (float)freqHi },
else regulValveStableTime,
{ true);
controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency, }
new float[2] { (float)freqLo, (float)freqHi }, else
regulValveStableTime); {
controlBoard.ValveMove(regulValveNr, RegulValveMode.TargetFrequency,
new float[2] { (float)freqLo, (float)freqHi },
regulValveStableTime);
}
} }
opState = OpState.OpCompleted; opState = OpState.OpCompleted;

19
TBF/BenchControl/TestMethods/FixedStartMassCollection/FixedStartMassCollectionSeq.cs
View File

@ -427,6 +427,20 @@ namespace TBF.BenchControl.TestMethods.FixedStartMassCollection
temperature_set: temperature_set:
State.Create(string.Format("{0}({1}) : Starting the test", test.Method, test.Name))
.AddOperation(checkUiOp)
.AddOperations(readTempPressOps)
.AddOperation(cBrd.StartMeasurementOp(outPath, (Elde.TestMethods.Diverter | Elde.TestMethods.FixedStart),
test.Qfrom, test.Qto, 2 * totalPulses, 10))
.EnterState();
do
{
e = StateMachine.WaitRunDevsRunOps();
if (e.Contains(Event.Error)) { retVal = Event.Error; goto stopTest; }
if (TestAndLogUiCmdStop(test, e)) { retVal = Event.UiCmdStop; goto stopTest; }
}
while (!e.Contains(Event.MeasurementStarted));
//----------------------------------------------------------------- //-----------------------------------------------------------------
Bridge.OnActivity(this, Strings.Stopping_flow_for_the_fixed_start); Bridge.OnActivity(this, Strings.Stopping_flow_for_the_fixed_start);
//----------------------------------------------------------------- //-----------------------------------------------------------------
@ -620,15 +634,14 @@ namespace TBF.BenchControl.TestMethods.FixedStartMassCollection
.AddOperation(checkUiOp) .AddOperation(checkUiOp)
.AddOperations(readTempPressOps) .AddOperations(readTempPressOps)
.AddOperation(new TBF.BenchControl.Elde.SetValvesOp(cBrd, false, outPath)) /// This line should precede StartMeasureentOp (sending commands) .AddOperation(new TBF.BenchControl.Elde.SetValvesOp(cBrd, false, outPath)) /// This line should precede StartMeasureentOp (sending commands)
.AddOperation(cBrd.StartMeasurementOp(outPath, (Elde.TestMethods.Diverter | Elde.TestMethods.FixedStart), .AddOperation(outPath.RegulValve.SetFlowOp(outPath.FlowMeter, test.Qfrom, test.Qto, RefFlow, int.MaxValue))
test.Qfrom, test.Qto, 2 * totalPulses, 10))
.EnterState(); .EnterState();
do { do {
e = StateMachine.WaitRunDevsRunOps(); e = StateMachine.WaitRunDevsRunOps();
if (e.Contains(Event.Error)) { retVal = Event.Error; goto stopTest; } if (e.Contains(Event.Error)) { retVal = Event.Error; goto stopTest; }
if (TestAndLogUiCmdStop(test, e)) { retVal = Event.UiCmdStop; goto stopTest; } if (TestAndLogUiCmdStop(test, e)) { retVal = Event.UiCmdStop; goto stopTest; }
} }
while (!e.Contains(Event.MeasurementStarted) || !e.Contains(Event.ValvesSet)); while (!e.Contains(Event.ValvesSet));
switchTimeStart = 0.001f * cBrd.ValveOpenCloseTime; switchTimeStart = 0.001f * cBrd.ValveOpenCloseTime;
log.WarnFormat("Start valve switch time on test start = {0} ms", cBrd.ValveOpenCloseTime); log.WarnFormat("Start valve switch time on test start = {0} ms", cBrd.ValveOpenCloseTime);

4
TBF/Properties/AssemblyInfo.cs
View File

@ -29,5 +29,5 @@ using System.Runtime.InteropServices;
// Build Number // Build Number
// Revision // Revision
// //
[assembly: AssemblyVersion("2.26.1769.0")] [assembly: AssemblyVersion("2.26.1770.0")]
[assembly: AssemblyFileVersion("2.26.1769.0")] [assembly: AssemblyFileVersion("2.26.1770.0")]