From 6071d7f598cb67872bf60d4bb6375dc0a4eabd2f Mon Sep 17 00:00:00 2001
From: Milan Hanajik <milan.hanajik@xyleminc.com>
Date: Wed, 5 Jan 2022 12:30:44 +0100
Subject: [PATCH] Bug fixes : Ambient temperature, pressure, humidity
 calculation in Results.

---
 Results/Entities/Batch.cs | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/Results/Entities/Batch.cs b/Results/Entities/Batch.cs
index de72f7ef2..cbea7b148 100644
--- a/Results/Entities/Batch.cs
+++ b/Results/Entities/Batch.cs
@@ -208,7 +208,7 @@ namespace Results.Entities
 
             foreach (var tr in TestRslts)
             {
-                if (tr.TestDone)
+                if (tr.TestDone && tr.AmbTempMean != 0)
                 {
                     double duration = (tr.EndTime - tr.StartTime).TotalSeconds;
                     timeSum += duration;
@@ -226,7 +226,7 @@ namespace Results.Entities
 
             foreach (var tr in TestRslts)
             {
-                if (tr.TestDone)
+                if (tr.TestDone && tr.AmbPressMean != 0)
                 {
                     double duration = (tr.EndTime - tr.StartTime).TotalSeconds;
                     timeSum += duration;
@@ -244,7 +244,7 @@ namespace Results.Entities
             
             foreach (var tr in TestRslts)
             {
-                if (tr.TestDone)
+                if (tr.TestDone && tr.AmbHumiMean != 0)
                 {
                     double duration = (tr.EndTime - tr.StartTime).TotalSeconds;
                     timeSum += duration;
@@ -259,7 +259,7 @@ namespace Results.Entities
         {
             for (int i = 0; i < TestRslts.Count; i++)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbTempStart != 0)
                     return TestRslts[i].AmbTempStart;
             }
             return 0;
@@ -268,7 +268,7 @@ namespace Results.Entities
         {
             for (int i = 0; i < TestRslts.Count; i++)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbPressStart != 0)
                     return TestRslts[i].AmbPressStart;
             }
             return 0;
@@ -277,7 +277,7 @@ namespace Results.Entities
         {
             for (int i = 0; i < TestRslts.Count; i++)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbHumiStart != 0)
                     return TestRslts[i].AmbHumiStart;
             }
             return 0;
@@ -285,27 +285,27 @@ namespace Results.Entities
 
         public virtual double AmbTempEnd()
         {
-            for (int i = TestRslts.Count - 1; i >= 0; i++)
+            for (int i = TestRslts.Count - 1; i >= 0; i--)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbTempEnd != 0)
                     return TestRslts[i].AmbTempEnd;
             }
             return 0;
         }
         public virtual double AmbPressEnd()
         {
-            for (int i = TestRslts.Count - 1; i >= 0; i++)
+            for (int i = TestRslts.Count - 1; i >= 0; i--)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbPressEnd != 0)
                     return TestRslts[i].AmbPressEnd;
             }
             return 0;
         }
         public virtual double AmbHumiEnd()
         {
-            for (int i = TestRslts.Count - 1; i >= 0; i++)
+            for (int i = TestRslts.Count - 1; i >= 0; i--)
             {
-                if (TestRslts[i].Publish() == Common.Publish.Always)
+                if (TestRslts[i].Publish() == Common.Publish.Always && TestRslts[i].AmbHumiEnd != 0)
                     return TestRslts[i].AmbHumiEnd;
             }
             return 0;